[Webkit-unassigned] [Bug 87167] [chromium] Cleanup scissor rect computation/use with damage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87167





--- Comment #28 from Dana Jansens <danakj at chromium.org>  2012-05-31 06:23:11 PST ---
(In reply to comment #27)
> (From update of attachment 144908 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144908&action=review
> 
> >> Source/WebCore/ChangeLog:13
> >> +        Covered by existing layout tests. Introduced more unit tests to
> > 
> > Its worth pointing out that damage tracking and scissoring aren't actually covered by layout tests.  DumpRenderTree reads back from the backbuffer, and therefore partial swap (and hence the scissoring) doesn't apply in those cases.  This can possibly be fixed in the long run for "repaint" layout tests, but in general it is just the nature of layout tests that prevents it.
> 
> I meant that the code changes were not supposed to change any functionality therefore no new e2e tests are needed. Existing tests would catch if we broke something unrelated. The scissorRect computation is covered by unit tests.
> 
> >> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:74
> >> +    FloatRect clipAndDamage = CCMathUtil::projectClippedRect(inverseScreenSpaceTransform, rootDamageRect);
> > 
> > Since we removed that helper function, I think we should add a comment here now that makes it clear what we're doing with this transform (i.e. that we're computing the damage in local surface space, where the rootDamageRect is in root surface space.)
> 
> Let's bring back the helper function. It will be duplicated in 2 places now (because we merged the calcScissorRects, but oh well), but right now I'll need to paste the same comment in THREE places. When we merge the surface classes, one implementation will go away, and then we can move it into more appropriate place.

Sure, let's call it like the variable would be, something like computeRootScissorRectInCurrentSurface(rootScissorRect)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.