[Webkit-unassigned] [Bug 87935] [EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87935





--- Comment #5 from Seokju Kwon <seokju.kwon at samsung.com>  2012-05-31 04:21:13 PST ---

(In reply to comment #2)
> (From update of attachment 145017 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145017&action=review
> 
> > Source/WebKit/efl/ChangeLog:8
> > +        It is the first step to support for Web Inspector in WebKit-EFL DRT
>
> Please write patch description for each ChangeLog more detail. In addition, put a period at the end line.
Done!

> > Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:150
> > +    evas_object_focus_set(inspector, EINA_TRUE);
> 
> Use true instead of EINA_TRUE.
Done!

> > Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:590
> > +    Evas_Object** view = static_cast<Evas_Object **>(eventInfo);
> 
> Should you need to use ** pointer in here ?
As you know, Evas smart callback can not return a value. And Use ** pointer for returning a pointer from callback function. 

> > LayoutTests/ChangeLog:8
> > +        It is the first step to support for Web Inspector in WebKit-EFL DRT
> 
> This is not proper description for this change. Re-write description.
Done!

> > LayoutTests/platform/efl/Skipped:300
> > +#inspector
> 
> Remove this all instead of comment.
Done!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.