[Webkit-unassigned] [Bug 87935] [EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87935





--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-05-31 02:19:18 PST ---
(From update of attachment 145017)
View in context: https://bugs.webkit.org/attachment.cgi?id=145017&action=review

> Source/WebKit/efl/ChangeLog:8
> +        It is the first step to support for Web Inspector in WebKit-EFL DRT

Please write patch description for each ChangeLog more detail. In addition, put a period at the end line.

> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:150
> +    evas_object_focus_set(inspector, EINA_TRUE);

Use true instead of EINA_TRUE.

> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:590
> +    Evas_Object** view = static_cast<Evas_Object **>(eventInfo);

Should you need to use ** pointer in here ?

> LayoutTests/ChangeLog:8
> +        It is the first step to support for Web Inspector in WebKit-EFL DRT

This is not proper description for this change. Re-write description.

> LayoutTests/platform/efl/Skipped:300
> +#inspector

Remove this all instead of comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.