[Webkit-unassigned] [Bug 87874] [chromium] Expose device scale factor in WebPluginContainer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 30 15:27:23 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=87874





--- Comment #8 from Josh Horwich <jhorwich at chromium.org>  2012-05-30 15:27:23 PST ---
(In reply to comment #6)
> (From update of attachment 144872 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144872&action=review
> 
> > Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:255
> > +float WebPluginContainerImpl::getDeviceScaleFactor()
> > +{
> > +    Page* page = m_element->document()->page();
> > +    if (!page)
> > +        return 1.0;
> > +    Settings* settings = page->settings();
> > +    if (!settings)
> > +        return 1.0;
> > +    return settings->defaultDeviceScaleFactor();
> > +}
> 
> Can we hold off on this API until http://lists.webkit.org/pipermail/webkit-dev/2012-May/020847.html gets resolved?  It's likely that this will need to change or at least be renamed.

Yes, I think holding off until the dust settles from that discussion would be wise. Thank you for pointing it out to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list