[Webkit-unassigned] [Bug 87167] [chromium] Cleanup scissor rect computation/use with damage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87167





--- Comment #24 from Shawn Singh <shawnsingh at chromium.org>  2012-05-30 15:10:22 PST ---
I think we're having a little bit of terminology confusion:

Swapping doesn't really have meaning, in my opinion, for renderSurfaces.  The way I see it, we should have the following definitions:

damageRect: the rect that represents a region that has changed on a surface

clipRect: the rect that represents a region that clips a layer/surface

scissorRect:  the rect that is actually given to glScissor, used to avoid redrawing stuff that hasn't changed, or to avoid drawing stuff that should actually be clipped.  that means its the intersection of damage and clip (assuming both damage and clip are being used on that particular layer)

swapRect: The rect that needs to be swapped from back-buffer to front buffer at the very end of our compositing algorithm. -- doesn't seem to be relevant to this patch, and maybe the word swap shouldn't even come up?

If we use that terminology, I think it makes sense to *not* use swapRect. in those places. I think we really do mean damage in those cases.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.