[Webkit-unassigned] [Bug 87853] the imageSmoothingEnabled flag needs to be in the state object

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87853





--- Comment #2 from Stephen White <senorblanco at chromium.org>  2012-05-30 13:38:40 PST ---
(From update of attachment 144903)
View in context: https://bugs.webkit.org/attachment.cgi?id=144903&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:2283
> +    modifiableState().m_imageSmoothingEnabled = enabled;

Could you put this line right below the realizeSaves() call?  Most other state modifiers seem to do that.

> LayoutTests/fast/canvas/canvas-imageSmoothingEnabled-expected.txt:10
> +Test restore works. We save a false state; create, then save a true state; and then finally restore.

Nit:  "Test restore works" -> "Test that restore works".

> LayoutTests/fast/canvas/canvas-imageSmoothingEnabled-expected.txt:25
> +Test restoring actually changes smoothing and not just the attribute value. We are restoring to a point where imageSmoothingEnabled is set to false.

Nit:  "Test restoring" -> "Test that restoring"

> LayoutTests/fast/canvas/script-tests/canvas-imageSmoothingEnabled.js:11
> +debug("Test restore works. We save a false state; create, then save a true state; and then finally restore.");

Same as above.

> LayoutTests/fast/canvas/script-tests/canvas-imageSmoothingEnabled.js:68
> +debug("Test restoring actually changes smoothing and not just the attribute value. We are restoring to a point where imageSmoothingEnabled is set to false.");

Same as above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.