[Webkit-unassigned] [Bug 87889] REGRESSION(118913): webarchive/test-xml-stylesheet.xml is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87889





--- Comment #2 from Alexey Proskuryakov <ap at webkit.org>  2012-05-30 13:22:16 PST ---
-    addSubresourceAttributeURLs(urls);
+    if (!isElementNode())
+        return;
+    static_cast<const Element*>(this)->collectSubresourceURLsFromAttributes(urls);

This means that we're not collecting from ProcessingInstructions anyway. An OVERRIDE annotation would have caught that.

I think that the patch should be rolled out. Given that these functions are collecting URLs from more than just element attributes, new names seem misleading (and that's how the regression got introduced anyway). Some kind of renaming (with OVERRIDE) seems appropriate, but it seems easier to do in a new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.