[Webkit-unassigned] [Bug 87533] Crash in styleForFirstLetter (pseudoStyle is null)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87533





--- Comment #14 from Julien Chaffraix <jchaffraix at webkit.org>  2012-05-30 11:33:39 PST ---
(From update of attachment 144877)
View in context: https://bugs.webkit.org/attachment.cgi?id=144877&action=review

> Source/WebCore/ChangeLog:9
> +        Adding null check for Pseudo element's RenderStyle as getCachedPseudoStyle returns null in different scenarios.
> +        In this case, null is returned from StyleResolver::pseudoStyleForElement when the matchedProperties list is empty.

Please update your ChangeLog, it mentions matchedProperties which bears little (if any) relation to the fix.

> Source/WebCore/rendering/RenderBlock.cpp:6074
> +    if (!pseudoStyle)
> +        return;

Why are we calling createFirstLetterRenderer if we don't have a first letter in this case? You haven't answered this question and without that, we can't assess if your patch is right.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.