[Webkit-unassigned] [Bug 87167] [chromium] Cleanup scissor rect computation/use with damage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87167





--- Comment #12 from Shawn Singh <shawnsingh at chromium.org>  2012-05-30 10:32:23 PST ---
(From update of attachment 143848)
I havent looked closely, but here's one reply you guys asked about.  I'll take a closer look at the next patch whenever Zeev has time to submit it.

View in context: https://bugs.webkit.org/attachment.cgi?id=143848&action=review

>>> Source/WebCore/platform/graphics/chromium/cc/CCRenderSurface.cpp:474
>>> +        surfaceDamageRect = inverseScreenSpaceTransform.mapRect(damageRect);
>> 
>> This should be using CCMathUtil::projectClippedRect. And the hasPerspective check can just go away. Does that make it more reasonable to do this externally, as it's just a project on the root rect using the surface's screen space inverse transform?
>> 
>> Shawn can you verify what I just said here is true?
> 
> It sure would if we could remove the call to this from CCLayerTreeHostImpl::drawLayers and just use root surface's scissorRect instead. Would that make sense?

In theory, yes, we can use CCMathUtil and remove the hasPerspective() case.  However, I had wanted to double-check this before changing it.  For unrelated reasons, it turns out I'll need to verify this and make the change sometime this week, so that works out.

Zeev, it looks like you have basically taken this code from a different place, right?  I think its OK to leave it the way it is for now, and I'll probably end up changing it in a different patch myself very soon.  Lets just keep tabs on who lands their patch first, and the other person can accommodate the new code in their patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.