[Webkit-unassigned] [Bug 87842] [WK2-Gtk]Compilation errors with flag CONTEXT_MENUS=0

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87842


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144779|review?                     |review-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2012-05-30 10:31:25 PST ---
(From update of attachment 144779)
View in context: https://bugs.webkit.org/attachment.cgi?id=144779&action=review

Looks good, but I don't think you're a committer, so r- for some minor issues.

> Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp:30
> +
> +#if ENABLE(CONTEXT_MENUS)
> +
>  #include "WebContextMenuProxyGtk.h"

See below.

> Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:30
>  #include "config.h"
> +
> +#if ENABLE(CONTEXT_MENUS)
> +

WebContextMenuClient.h already seems to be guarded by ENABLE(CONTEXT_MENUS) so you can move the #ifdef down before the second block.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.