[Webkit-unassigned] [Bug 72099] [WK2] Keyboard menu key should show context menu

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72099


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144798|review?                     |review-
               Flag|                            |




--- Comment #12 from Martin Robinson <mrobinson at webkit.org>  2012-05-30 10:28:51 PST ---
(From update of attachment 144798)
View in context: https://bugs.webkit.org/attachment.cgi?id=144798&action=review

Looks alright apart from a few small issues. r- because of the build break though.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:468
> +    WebKitWebViewBase* webViewBase = WEBKIT_WEB_VIEW_BASE(widget);
> +    WebKitWebViewBasePrivate* priv = webViewBase->priv;
> +#if ENABLE(CONTEXT_MENUS)
> +    priv->pageProxy->handleContextMenuKeyEvent();
> +#endif // ENABLE(CONTEXT_MENUS)

I think it makes sense to just write:

#if ENABLE(CONTEXT_MENUS)
WEBKIT_WEB_VIEW_BASE(widget)->priv->pageProxy->handleContextMenuKeyEvent();
#endif

Shouldn't you return true here in side the #ifdef?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.