[Webkit-unassigned] [Bug 87337] [Blackberry] WebKit's fullscreen mode needs to notify page client.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87337





--- Comment #9 from Chris.Guan <chris.guan at torchmobile.com.cn>  2012-05-30 05:33:33 PST ---
(In reply to comment #7)
> (From update of attachment 144780 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144780&action=review
> 
> > Source/WebKit/blackberry/Api/WebPage.cpp:6061
> > +    // Search for a video element in this document.
> > +    Document* document = frame->document();
> > +    for (Node* node = document->firstChild(); node; node = node->traverseNextNode(document)) {
> > +        if (!node->isElementNode())
> > +            continue;
> > +        if (node->hasTagName(HTMLNames::videoTag))
> > +            return true;
> > +    }
> > +
> > +    // Do the same for the nested frames.
> > +    for (Frame* child = frame->tree()->firstChild(); child; child = child->tree()->nextSibling()) {
> > +        if (containsVideoTags(child))
> > +            return true;
> 
> that can be VERY slow. r- due to that.
yes, I think so. we do not need to check frame probably, Thanks.
> 
> > Source/WebKit/blackberry/Api/WebPage.cpp:6082
> > +#if ENABLE(VIDEO)
> 
> can you have #fullscreen_api enabled and #video disabled?
I think it is possible, fullscreen_api is for all elements. But for some secure concerns, we only apply fullscreen mode to video tags or those elements containing video tags.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.