[Webkit-unassigned] [Bug 87337] [Blackberry] WebKit's fullscreen mode needs to notify page client.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87337


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144780|review?                     |review-
               Flag|                            |




--- Comment #7 from Antonio Gomes <tonikitoo at webkit.org>  2012-05-30 04:50:10 PST ---
(From update of attachment 144780)
View in context: https://bugs.webkit.org/attachment.cgi?id=144780&action=review

> Source/WebKit/blackberry/Api/WebPage.cpp:6061
> +    // Search for a video element in this document.
> +    Document* document = frame->document();
> +    for (Node* node = document->firstChild(); node; node = node->traverseNextNode(document)) {
> +        if (!node->isElementNode())
> +            continue;
> +        if (node->hasTagName(HTMLNames::videoTag))
> +            return true;
> +    }
> +
> +    // Do the same for the nested frames.
> +    for (Frame* child = frame->tree()->firstChild(); child; child = child->tree()->nextSibling()) {
> +        if (containsVideoTags(child))
> +            return true;

that can be VERY slow. r- due to that.

> Source/WebKit/blackberry/Api/WebPage.cpp:6082
> +#if ENABLE(VIDEO)

can you have #fullscreen_api enabled and #video disabled?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.