[Webkit-unassigned] [Bug 87578] [FileAPI] The result attribute of FileReader shuold use null to replace empty string

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87578





--- Comment #17 from Li Yin <li.yin at intel.com>  2012-05-29 22:50:42 PST ---
(In reply to comment #15)
> nit: two "if" can be concatenated like If the readyState is EMPTY (...) or an error occurs ...

Done

> 
> > Source/WebCore/ChangeLog:17
> > +
> 
> nit: extra empty line is not needed.
>

Done

> > LayoutTests/fast/files/resources/read-file-test-cases.js:221
> > +    log("result before calling reading method: " + readerToTestReread.result)
> 
> Why is this check being added to this test testReadAgainAfterFailedReadStep1? Why not adding a new async test case like testResultBeforeRead?

Done.

Thanks for your review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.