[Webkit-unassigned] [Bug 87578] [FileAPI] The result attribute of FileReader shuold use null to replace empty string

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87578


Jian Li <jianli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144686|review?                     |review-
               Flag|                            |




--- Comment #15 from Jian Li <jianli at chromium.org>  2012-05-29 22:12:26 PST ---
(From update of attachment 144686)
View in context: https://bugs.webkit.org/attachment.cgi?id=144686&action=review

> Source/WebCore/ChangeLog:10
> +        Or if an error in reading the File or Blob has occurred (using any read method),

nit: two "if" can be concatenated like If the readyState is EMPTY (...) or an error occurs ...

> Source/WebCore/ChangeLog:17
> +

nit: extra empty line is not needed.

> LayoutTests/fast/files/resources/read-file-test-cases.js:221
> +    log("result before calling reading method: " + readerToTestReread.result)

Why is this check being added to this test testReadAgainAfterFailedReadStep1? Why not adding a new async test case like testResultBeforeRead?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.