[Webkit-unassigned] [Bug 87696] [FileAPI] Miss FileList test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 29 21:43:49 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=87696





--- Comment #16 from Li Yin <li.yin at intel.com>  2012-05-29 21:43:48 PST ---
(In reply to comment #14)
> (From update of attachment 144532 [details])
> Thanks for adding test cases for FileList. Here're some minor comments that you could consider addressing them in another patch.
> 
> View in context: https://bugs.webkit.org/attachment.cgi?id=144532&action=review
> 
> > LayoutTests/fast/files/file-list-test.html:22
> > +    shouldBeNull("files.item(999)");
> 
> Could you please also add some more tests to cover the cases that 2, null, or undefined is passed as index.
>

There is a bug about the negative index, https://bugs.webkit.org/show_bug.cgi?id=77899
If we want to support negative index, I think the FileList.idl will be changed, and maybe the behavior will be different when the index is null, undefined.(I am not sure.)

So, currently, I only cover the expected index. And it will be improved in the bug77899.

> Please also test the scenario that no file is selected.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list