[Webkit-unassigned] [Bug 84048] ShadowRoot needs resetStyleInheritance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84048


Hajime Morrita <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144435|review?                     |review-
               Flag|                            |




--- Comment #31 from Hajime Morrita <morrita at google.com>  2012-05-29 19:07:15 PST ---
(From update of attachment 144435)
View in context: https://bugs.webkit.org/attachment.cgi?id=144435&action=review

The attempt looks right. Let's iterate once to factor code a bit.

> Source/WebCore/css/StyleResolver.cpp:1173
> +    if (resetStyleInheritance)

This can be inside if (e) block above.

> Source/WebCore/css/StyleResolver.cpp:1660
> +        if (m_checker.document()->settings()) {

I guess you can check frame() or page() here. Checking settings() is cryptic.
Is it possible to extract these if/else to a function or method?
Having many conditionals here in the same function looks too complicated.

My feeling is that it's worth to have a method for creating an initial style
instead of making it up inline here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.