[Webkit-unassigned] [Bug 87801] [GTK] Remove geoclue dependency from WebKit API Layer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87801





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2012-05-29 18:20:15 PST ---
(From update of attachment 144665)
View in context: https://bugs.webkit.org/attachment.cgi?id=144665&action=review

> Source/WebKit/gtk/GNUmakefile.am:-60
> -	$(GEOCLUE_CFLAGS) \

I'm pretty certain you need to keep these flags here. Note that libxslt is on the list.

> Source/WebKit/gtk/WebCoreSupport/GeolocationClientGtk.h:62
> +    RefPtr<WebCore::GeolocationProviderGeoclue> m_provider;

Instead of making this reference-counted and a pointer, it makes more sense, I think, to just make it a member, ie

WebCore::GeolocationProvider m_provider;

You can then initialize it like this

, m_provider(this)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.