[Webkit-unassigned] [Bug 87717] Unresponsive WebProcesses can be mistaken for crashes.

Tue May 29 12:07:09 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=87717

Dirk Pranke <dpranke at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144497|review?                     |review+
               Flag|                            |

--- Comment #3 from Dirk Pranke <dpranke at chromium.org>  2012-05-29 12:07:09 PST ---
(From update of attachment 144497)
View in context: https://bugs.webkit.org/attachment.cgi?id=144497&action=review

The patch looks fine. I'm not sure how you're defining "unresponsive" in WebKit2, but does it make sense to map these things onto TIMEOUTs rather than CRASHes?

> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:588
> +            crash_log += '  Process failed to become responsive before timing out.'

See my comment in bug 87714 about possibly changing the interface to _get_crash_log() so that you don't have to do the .startswith() check here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.