[Webkit-unassigned] [Bug 85527] [Qt][WK2] Add support for multi-select list

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85527





--- Comment #15 from Pierre Rossi <pierre.rossi at gmail.com>  2012-05-29 08:20:54 PST ---
(From update of attachment 144141)
View in context: https://bugs.webkit.org/attachment.cgi?id=144141&action=review

>From an API point of view in QML, I'm missing something in that change: the fact that a multiple picker is needed or not. I think a "multiple" property of some sort should be exposed in the context object to enforce single selection when the select element expects only one item to be picked and allow picking multiple in other cases.
So essentially one could have two different components for that. I think I'd also have gone for overloads taking a list or a vector of the selected indices and passing that only once to the web process once the selection process is over rather than trying to stick too closely to the very synchronous listbox approach.

>>> Source/WebKit2/Shared/PlatformPopupMenuData.cpp:67
>>> +#elif PLATFORM(QT)
>> 
>> I thnk there were another if def used in the theme itself when delegation of multiply selection was used
> 
> Please let me know if there is any other way of getting this information.

Actually it's now a runtime thing in RenderTheme (RenderTheme::delegatesMenuListRendering which returns false by default but is reimplemented in the mobile theme to return true). So in that case I think PLATFORM(QT) is the right thing to use.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.