[Webkit-unassigned] [Bug 87283] [GTK] run-file-chooser signal for WebKit1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87283


Daniel Drake <dsd at laptop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144053|0                           |1
        is obsolete|                            |
 Attachment #144053|review?                     |
               Flag|                            |
 Attachment #144555|                            |review?
               Flag|                            |




--- Comment #10 from Daniel Drake <dsd at laptop.org>  2012-05-29 07:35:47 PST ---
Created an attachment (id=144555)
 --> (https://bugs.webkit.org/attachment.cgi?id=144555&action=review)
updated patch for review

Thanks! Here's a new patch addressing those comments.

If there is not much focus on making WebKit1 and WebKit2 gobject APIs similar, I agree with removing the cancel method (done in the patch).

The one remaining issue I have here is that it complains during build:

/home/dsd/projects/WebKit-r118336/Source/WebKit/gtk/webkit/webkitfilechooserrequest.cpp:56: warning: Section WebKitFileChooserRequest is not defined in the webkitgtk-section.txt file.

Does it mean webkitgtk-sections.txt (with an 's')? I do have an entry there, and I can't see what I'm doing differently compared to other classes. Either way it does not seem to affect the functionality.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.