[Webkit-unassigned] [Bug 87701] [Qt] REGRESSION(r118616): It made all tests crash in debug mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87701





--- Comment #2 from Zoltan Herczeg <zherczeg at webkit.org>  2012-05-29 06:20:17 PST ---
(In reply to comment #1)
> QtInstance::m_methods needs to be a HashMap with a Weak<JSObject> value type. I would make this change myself but I'm not familiar with QHash and QByteArray, and the QtInstance object model has a lot of friend relationships and poor modularity, which makes it hard for me to have confidence in a code change just by reading a subsection of the Qt codebase.

Hi Geoff, thanks for the help. I know the design is flawed there, but still I would like to fix it. However, I got all kinds of compiler errors (when playing with PassWeak), so please tell me how this thing should work.

Perhaps some different implementation for this could also be help:

void QtRuntimeMethodData::finalize(Handle<Unknown> value, void*)
{
    m_instance->removeCachedMethod(static_cast<JSObject*>(value.get().asCell()));
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.