[Webkit-unassigned] [Bug 87696] [FileAPI] Miss FileList test

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87696


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144455|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #3 from Kentaro Hara <haraken at chromium.org>  2012-05-29 01:17:14 PST ---
(From update of attachment 144455)
View in context: https://bugs.webkit.org/attachment.cgi?id=144455&action=review

The change looks OK.

> LayoutTests/fast/files/file-list-test.html:17
> +    debug("files.item(0): " + files.item(0));

Nit: Maybe we want to pass more than two files for testing?

> LayoutTests/fast/files/file-list-test.html:32
> +function runTests()
> +{
> +    eventSender.beginDragWithFiles(['resources/UTF8.txt']);
> +    eventSender.mouseMoveTo(10, 10);
> +    eventSender.mouseUp();
> +}
> +
> +if (window.eventSender) {
> +    layoutTestController.dumpAsText();
> +    window.onload = runTests;
> +}

I guess you can simplify the code.

- You do not need to call layoutTestController.dumpAsText().
- You can write the <script> after </body>, by which you can avoid hooking window.onload.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.