[Webkit-unassigned] [Bug 87687] Check for GTK2/GTK3 symbol mismatch earlier

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87687


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com,
                   |                            |msanchez at igalia.com




--- Comment #1 from Mario Sanchez Prada <msanchez at igalia.com>  2012-05-29 00:29:45 PST ---
(In reply to comment #0)
> Created an attachment (id=144423)
 --> (https://bugs.webkit.org/attachment.cgi?id=144423&action=review) [details]
> patch
> 
> WebKit2 move plugins into their own process, but WebKit1 (built for GTK3) 
> is left with the limitation that if a plugin links against GTK2, it will 
> fail to run.

Yes, that's a known issue :-(

> nspluginwrapper could maybe work around this issue, by adding in a process
> separation, but this doesn't work on current released WebKit. The affected 
> sites just show an empty box where the content should be.

Hmm... In my case, I've been using epiphany 3.x and WebKit1 (linking against GTK3) without problems with the flash plugin thanks to nspluginwrapper, so I don't know if I'm missing something here.

True to be told, my laptop is a 64bit system and works fine here, but I've never managed to make this "nspluginwrapper workaround" work in 32bit systems, which as far as I could read is a known limitation of nspluginwrapper.

So, maybe your system is a 32bit one and yuo have found a fix even for those systems? Otherwise (if you're using it in a 64bit environment) I think I'm missing something, because nspluginwrapper should work fine.

> Using Flash as an example, I dug down and found that the behaviour is 
> something like the following:
>  - Load both "real" libflashplayer and the wrapped libflashplayer
>  - Try to show the flash content using the real libflashplayer
>  - Abort because a mix of GTK2/GTK3 symbols was detected
> 
> And that's it - it didn't even try the wrapped libflashplayer which 
> advertises support for the same mime types.
> 
> I found a way to fix this: Move the GTK2/GTK3 symbol check earlier, and 
> don't even register plugins in the PluginDatabase if there is a symbol
> mismatch. See attached patch.

Nice! By the way, whenever you attach a patch and ask for review, you should take care of putting the "right" reviewers on CC, otherwise it might end up unattended.

As per the output of git blame, it see Carlos could be a good reviewer for this one, so adding him o CC now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.