[Webkit-unassigned] [Bug 73176] Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73176





--- Comment #38 from Dongwoo Joshua Im (dwim) <dw.im at samsung.com>  2012-05-28 18:34:11 PST ---
(In reply to comment #36)
> (From update of attachment 143726 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143726&action=review
> 
> > Source/WebCore/WebCore.vcproj/WebCore.vcproj:26381
> > +                RelativePath="..\page\CustomHandlersState.cpp"
> 
> The indent looks wrong here.  I think this file uses tabs.

Ok. I will fix it.

> 
> > Source/WebKit/chromium/src/ChromeClientImpl.cpp:504
> > +    notImplemented();
> > +    return "declined";
> 
> This gives the wrong answer.

Yes.
I think I can change like below, because I will introduce new macro which is disabled in Chromium port.

    notImplemented();
+    ASSERT_NOT_REACHED();
+    return "";
-    return "declined";

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.