[Webkit-unassigned] [Bug 80135] [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80135


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144364|review?                     |review+
               Flag|                            |




--- Comment #25 from Rob Buis <rwlbuis at gmail.com>  2012-05-28 11:19:18 PST ---
(From update of attachment 144364)
View in context: https://bugs.webkit.org/attachment.cgi?id=144364&action=review

Looks good but please fix my issues before landing.

> Source/WebCore/ChangeLog:9
> +        issue for BlackBerry porting get identified and fixed.

It is better to keep the original ChangeLog messages. Or keep them and append these two lines too.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:130
> +    return "<unknown>";

This needs to be implemented? If so add a TODO.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:877
> +    return true;

Is this tested? Do you think we will need to change some test results?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.