[Webkit-unassigned] [Bug 87665] [BlackBerry] http authentication challenge issue when loading favicon

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87665


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144360|review?                     |review+
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-05-28 10:44:01 PST ---
(From update of attachment 144360)
View in context: https://bugs.webkit.org/attachment.cgi?id=144360&action=review

Ok.

> Source/WebCore/ChangeLog:8
> +        Provided the TargetType when generating a favicon loading

Provide the TargetType

> Source/WebCore/ChangeLog:9
> +        request. Loading favicon is triggered after the main resource

Loading favicons

> Source/WebCore/ChangeLog:14
> +        loading, which may confuse user.

the user.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:764
> +            // The favicon loading is triggerred after the main resource has been loaded

Typo: triggered

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:767
> +            // load. If not we will receive another challenge which may confuse user.

Slightly better:

// and parsed, so if we cancel the authentication challenge when loading the main
// resource, we should also cancel loading the favicon when it starts to
// load. If not we will receive another challenge which may confuse the user.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.