[Webkit-unassigned] [Bug 87660] [BlackBerry] http authentication challenge issue when loading subresource

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87660


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144357|review?                     |review-
               Flag|                            |




--- Comment #3 from Rob Buis <rwlbuis at gmail.com>  2012-05-28 10:31:52 PST ---
(From update of attachment 144357)
View in context: https://bugs.webkit.org/attachment.cgi?id=144357&action=review

Looks good, but can maybe cleaned up some more.

> Source/WebCore/ChangeLog:14
> +        No new tests because of no behavior changed.

No new tests since there is no change in behavior.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:214
> +    // the saved credentials.

The comment is quite obvious, and the code below it is readable, maybe not needed.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:218
> +        purgeCredentials();

Is it useful to log the fact that there was an error? How about dealing with isError case first, you do not need the ! operation in that case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.