[Webkit-unassigned] [Bug 82155] DFG OSR exit value recoveries should be computed lazily

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82155


Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134256|review?                     |review+
               Flag|                            |




--- Comment #18 from Gavin Barraclough <barraclough at apple.com>  2012-05-28 01:34:32 PST ---
(From update of attachment 134256)
View in context: https://bugs.webkit.org/attachment.cgi?id=134256&action=review

It seems that it might be cleaner at some point to refactor GenerationInfo, so that rather than being a class representing a single value & having a Vector of them, to instead have GenerationInfo be a container holding info for N variables, and make all methods be passed the virtual register to be operated on.  Then the generation info could hold a reference to m_stream as a member, which would better encapsulate the implementation.

Apologies again on the delay on reviewing this, r+, please re-test performance before landing.

> Source/JavaScriptCore/bytecode/Operands.h:199
> +    // Use const-cast because:

:-(

> Source/JavaScriptCore/dfg/DFGMinifiedNode.h:42
> +    switch (type) {

Given that this happens around the node generation loop, I wonder if it might be worth trying to make this a faster test than a switch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.