[Webkit-unassigned] [Bug 87578] [FileAPI] The result attribute of FileReader shuold use null to replace empty string

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87578


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144205|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #2 from Kentaro Hara <haraken at chromium.org>  2012-05-26 15:05:45 PST ---
(From update of attachment 144205)
View in context: https://bugs.webkit.org/attachment.cgi?id=144205&action=review

> Source/WebCore/ChangeLog:12
> +        WebKit should change the returned value empty string into null to keep 
> +        conformance with the spec.

What are the behaviors of other browsers? We want to also keep cross-browser compatibility.

> Source/WebCore/fileapi/FileReader.cpp:248
> +    if (ret == "")

ret.IsEmpty() would be better.

> LayoutTests/fast/files/resources/read-common.js:174
> +    if (result == null) {

Please use === instead of ==. == in JavaScript is "ambiguous" and thus not suitable for testing purpose.

> LayoutTests/fast/files/resources/read-common.js:176
> +        return ;

Nit: No space needed before ';'

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.