[Webkit-unassigned] [Bug 87563] New: [BlackBerry] BackingStore accesses tiles even though it's not active

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 25 22:11:34 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=87563

           Summary: [BlackBerry] BackingStore accesses tiles even though
                    it's not active
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit BlackBerry
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: anilsson at rim.com
                CC: tonikitoo at webkit.org
        Depends on: 87562


PR #150403

            There are many scenarios that can call render and cause tile access,
            and they used to be rerouted to the direct rendering code when the
            backing store was not active. This was thanks to an implicit check for
            isActive() by virtue of calling shouldDirectRenderingToWindow() from
            render().

            If we're using OpenGL for compositing the backing store contents
            however, direct rendering is always disabled and we jump right into the
            tile based rendering code.

            Fixed by adding an explicit check for isActive() in render(), now that
            the implicit check in shouldDirectRenderingToWindow() is conditional on
            having raster usage.

            Since PR136381/bug83131, when OpenGL compositing is used, and the
            backing store is not active, it is not in charge of drawing the root
            layer. Instead, we switch off the paintingGoesToWindow flag on the root
            RenderLayer so no invalidates will reach the ChromeClient or the
            BackingStore any more. Instead, invalidations will cause the root
            accelerated compositing layer to be repainted. Any BackingStore render
            calls while in this state are pointless, and can safely do an early
            return.

            Reviewed internally by Jakob Petsovits.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list