[Webkit-unassigned] [Bug 87418] WebBackForwardList should separate "has no current index" from the integer value of the current index

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87418





--- Comment #5 from Brady Eidson <beidson at apple.com>  2012-05-25 13:38:07 PST ---
(In reply to comment #4)
> > Source/WebKit2/UIProcess/cf/WebBackForwardListCF.cpp:190
> >      // Perform a sanity check: in case we're out of range, we reset.
> > -    if (m_current != NoCurrentItemIndex && m_current >= newEntries.size())
> > -        m_current = NoCurrentItemIndex;
> > +    if (m_hasCurrentIndex && m_currentIndex >= newEntries.size())
> > +        m_hasCurrentIndex = false;
> 
> We don’t need this sanity check because it’s redundant with checks done above. I thought you were going to remove it and replace it with an assertion in this patch.

I have a *much* more thorough patch than this one I plan to do in https://bugs.webkit.org/show_bug.cgi?id=87513

Adding the bool and doing the m_current rename seemed like a separate enough task to split it off separately.

That said, I'll make many of the tweaks you suggested here before landing, and make sure everything is addressed in bug 87513

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.