[Webkit-unassigned] [Bug 86557] Allow WebTextFieldDecoratorClient to see applied decorations.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86557





--- Comment #31 from Garrett Casto <gcasto at chromium.org>  2012-05-25 10:46:18 PST ---
(In reply to comment #30)
> (In reply to comment #29)
> > > You should use setInlineStyleProperty() like you did in TextFieldDecorationElement::decorate().
> > > Setting style attribute is expensive.
> > 
> > I was originally using setInlineStyleProperty, but Dimitri recommended this instead. I'm fine with whichever. Dimitri, do you still think that this should use setAttribute?
> 
> I did, and I still think it's ok, since Web developers do this all the time -- but only if as means of removing the need for that whole extra file WebTextDecorationElement. Adding new WebKit API leads to pain of maintenance. If there are strong feelings, I would much rather expose setting inline style on WebElement.

Ahh, I totally misunderstood that comment then. I didn't realize that you wanted to get rid of WebTextFieldDecorationElement. I'm fine with that. For the moment I'll just use a WebElement and not expose setInlineStyleProperty. I can add that later if we so desire.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.