[Webkit-unassigned] [Bug 86296] Implement LayoutTest's eventSender.beginDragWithFiles interface in windows platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86296


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143991|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #16 from Tony Chang <tony at chromium.org>  2012-05-25 10:38:40 PST ---
(From update of attachment 143991)
View in context: https://bugs.webkit.org/attachment.cgi?id=143991&action=review

Looking much better.  Can you file a bug about check-webkit-style not running on Chinese Windows?  Please include a stack trace.

> Tools/DumpRenderTree/win/DRTDataObject.cpp:373
> +            m_formats[m_formats.size() - 1] = 0;
> +            m_formats.removeLast();

Do we need to set "m_formats[m_formats.size() - 1] = 0" if we're going to remove it?

> Tools/DumpRenderTree/win/DRTDataObject.h:68
> +    Vector<FORMATETC*> m_formats;
> +    Vector<STGMEDIUM*> m_medium;

Can we use Vector<OwnPtr<FORMATETC> > and Vector<OwnPtr<STGMEDIUM> >?

> Tools/DumpRenderTree/win/DRTDropSource.h:36
> +    virtual ULONG STDMETHODCALLTYPE AddRef(void);
> +    virtual ULONG STDMETHODCALLTYPE Release(void);

Can we remove void?

> Tools/DumpRenderTree/win/EventSender.cpp:668
> +    DROPFILES* dropFiles = reinterpret_cast<DROPFILES *>(GlobalLock(medium.hGlobal));

Nit: No space between DROPFILES and *.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.