[Webkit-unassigned] [Bug 73176] Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73176


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143726|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #36 from Adam Barth <abarth at webkit.org>  2012-05-25 09:27:24 PST ---
(From update of attachment 143726)
View in context: https://bugs.webkit.org/attachment.cgi?id=143726&action=review

If we were to land this patch as written, it would be wrong on PLATFORM(CHROMIUM).  Instead of breaking other ports, it might make sense to introduce a new ENABLE macro so that those ports can expose these APIs to the web when they work.

> Source/WebCore/WebCore.vcproj/WebCore.vcproj:26381
> +                RelativePath="..\page\CustomHandlersState.cpp"

The indent looks wrong here.  I think this file uses tabs.

> Source/WebKit/chromium/src/ChromeClientImpl.cpp:504
> +    notImplemented();
> +    return "declined";

This gives the wrong answer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.