[Webkit-unassigned] [Bug 87283] [GTK] run-file-chooser signal for WebKit1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87283





--- Comment #7 from Mario Sanchez Prada <msanchez at igalia.com>  2012-05-25 09:16:54 PST ---
(In reply to comment #6)
> Created an attachment (id=144053)
 --> (https://bugs.webkit.org/attachment.cgi?id=144053&action=review) [details]
> run-file-chooser ready for review
> 
> Thanks for the clear explanation, now I understand it better.

Glad to hear that.

> The test case failure can be fixed by moving to the same logic used in WebKit2, 
> which is as you describe. Here's an updated patch with all test cases working.

Thanks! Good to see you figured out the problem.

> Whats next?

I haven't time to checked the patch (last meeting this afternoon) and have to run now out of the office, but off the top of my head the next step would be to ask a  WebKit reviewer[1] (which I'm not yet) to review it by setting the r? flag in the "Details" link for the patch [2].

Still, I could make an informally review but I'm afraid that will have to wait until Monday, since I'm now already in a hurry. Hope it's fine

[1] http://www.webkit.org/coding/commit-review-policy.html
[2] http://www.webkit.org/coding/contributing.html

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.