[Webkit-unassigned] [Bug 76640] webkit-patch pretty-diff does not show image diffs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76640


Elliot Poger <epoger at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpranke at chromium.org,
                   |                            |ojan at chromium.org




--- Comment #3 from Elliot Poger <epoger at chromium.org>  2012-05-25 07:37:35 PST ---
See related thread: https://groups.google.com/a/chromium.org/d/topic/webkit-gardening/4YlZ6BK8Fgk/discussion ("garden-o-matic: how to review image rebaselines before committing?")

>From that thread, it sounds like we do want to maintain "webkit-patch pretty-diff" even though its functionality overlaps with "webkit-patch garden-o-matic".

Excerpts:

dpranke: "we should see if we can improve pretty-diff to share the pixel zooming code from g-o-m. "

ojan: "I don't think garden-o-matic is the right place to fix this. We should have pretty-diff pull a script that adds both pixel-zooming and JS-based pixel diffing."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.