[Webkit-unassigned] [Bug 73917] [Qt][WK2] fast/forms/access-key-for-all-elements.html fails

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 25 00:02:40 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=73917


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143652|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #7 from Simon Hausmann <hausmann at webkit.org>  2012-05-25 00:01:44 PST ---
(From update of attachment 143652)
View in context: https://bugs.webkit.org/attachment.cgi?id=143652&action=review

> Source/WebCore/platform/qt/UserAgentQt.cpp:29
> +#include <WebCore/SystemInfo.h>

This doesn't look correct... Why did you add the prefix?

> Source/WebCore/platform/qt/UserAgentQt.cpp:31
> +#include <WebKitVersion.h>

This I think is the main issue that's left with this patch/approach and I don't see a good way around it. It's a layer violation to call WebKit from within WebCore and in fact it's going to break the force_static_libs_as_shared build.

It doesn't quite feel right to move the WebKit version stuff also into WebCore, making me think that perhaps we need another static library for code that's shared between WebKit1 and WebKit2.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list