[Webkit-unassigned] [Bug 86296] Implement LayoutTest's eventSender.beginDragWithFiles interface in windows platform

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 24 23:22:24 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=86296


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #11 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-05-24 23:21:28 PST ---
Attachment 143985 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Tools/DumpRenderTree/win/DRTDropSource.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
Tools/DumpRenderTree/win/DRTDropSource.h:33:  This { should be at the end of the previous line  [whitespace/braces] [4]
Tools/DumpRenderTree/win/DRTDropSource.h:49:  Should have a space between // and comment  [whitespace/comments] [4]
Tools/DumpRenderTree/win/DRTDataObject.h:44:  Should have a space between // and comment  [whitespace/comments] [4]
Tools/DumpRenderTree/win/DRTDataObject.h:49:  Should have a space between // and comment  [whitespace/comments] [4]
Tools/DumpRenderTree/win/DRTDataObject.h:53:  Missing space after ,  [whitespace/comma] [3]
Tools/DumpRenderTree/win/DRTDataObject.h:71:  Should have a space between // and comment  [whitespace/comments] [4]
Tools/DumpRenderTree/win/DRTDataObject.cpp:51:  This { should be at the end of the previous line  [whitespace/braces] [4]
Tools/DumpRenderTree/win/DRTDataObject.cpp:56:  Should have a space between // and comment  [whitespace/comments] [4]
Tools/DumpRenderTree/win/DRTDataObject.cpp:61:  Should have a space between // and comment  [whitespace/comments] [4]
Tools/DumpRenderTree/win/DRTDataObject.cpp:155:  Declaration has space between type name and * in WCEnumFormatEtc *newEnum  [whitespace/declaration] [3]
Tools/DumpRenderTree/win/DRTDataObject.cpp:201:  Extra space after ( in function call  [whitespace/parens] [4]
Tools/DumpRenderTree/win/DRTDataObject.cpp:206:  Extra space after ( in function call  [whitespace/parens] [4]
Tools/DumpRenderTree/win/DRTDataObject.cpp:242:  Extra space between HRESULT and hResult  [whitespace/declaration] [3]
Tools/DumpRenderTree/win/DRTDataObject.cpp:245:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Tools/DumpRenderTree/win/DRTDataObject.cpp:250:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Tools/DumpRenderTree/win/DRTDataObject.cpp:297:  Missing space after ,  [whitespace/comma] [3]
Tools/DumpRenderTree/win/DRTDataObject.cpp:300:  Missing space after ,  [whitespace/comma] [3]
Tools/DumpRenderTree/win/DRTDataObject.cpp:303:  Missing space after ,  [whitespace/comma] [3]
Tools/DumpRenderTree/win/DRTDataObject.cpp:306:  Missing space after ,  [whitespace/comma] [3]
Tools/DumpRenderTree/win/DRTDataObject.cpp:309:  Missing space after ,  [whitespace/comma] [3]
Tools/DumpRenderTree/win/DRTDataObject.cpp:352:  Missing space after ,  [whitespace/comma] [3]
Tools/DumpRenderTree/win/EventSender.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
Tools/DumpRenderTree/win/EventSender.cpp:42:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 24 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list