[Webkit-unassigned] [Bug 87283] [GTK] run-file-chooser signal for WebKit1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87283





--- Comment #4 from Daniel Drake <dsd at laptop.org>  2012-05-24 19:59:19 PST ---
Created an attachment (id=143953)
 --> (https://bugs.webkit.org/attachment.cgi?id=143953&action=review)
Attempting to solve test failure

Tricky, I think.
webkit_file_chooser_request_get_selected_files() calls into request->priv->chooser->settings().selectedFiles. However, this doesn't seem to be updated when a new selection is made.

So I moved to caching the selected files in webkit_file_chooser_request_select_files() in the attached incremental patch. This fixes the test failure but then fails on a later test, where we select some files then click the button again and check that the selection was retained. This creates a new ChooserRequest object which has forgotten the selection of the first one.

I then tried caching the initially selected files by reading the settings from webkit_file_chooser_request_create() but this segfaults upon access to chooser->settings(), not sure why.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.