[Webkit-unassigned] [Bug 87419] [BlackBerry] Implement select popup and remove old hook to air popup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87419


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143899|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #3 from Rob Buis <rwlbuis at gmail.com>  2012-05-24 14:57:43 PST ---
(From update of attachment 143899)
View in context: https://bugs.webkit.org/attachment.cgi?id=143899&action=review

Looks good.

> Source/WebCore/Resources/blackberry/popupControlBlackBerry.css:66
> +}

I think this could have been placed in WebCore/css too, but this works as well.

> Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:147
> +        const WTF::Vector<HTMLElement*>& items = m_element->listItems();

You do not need the WTF:: prefix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.