[Webkit-unassigned] [Bug 87187] Acid3 fails in WebKit2 regression tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 24 13:38:40 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=87187





--- Comment #8 from Andras Becsi <abecsi at webkit.org>  2012-05-24 13:37:44 PST ---
(In reply to comment #7)
> > The issue seems to be "fixed" by enabling visited link tracking in the test with layoutTestController.keepWebHistory(), but this is obviously just hiding the real issue, which has already been reported four years ago. (https://bugs.webkit.org/show_bug.cgi?id=18146)
> 
> Could you please explain what the real issue is in more detail?
> 
> Bug 18146 has likely been resolved ages ago, as Acid3 has been fully passing in browser for years. So, it's not clear why there is any real issue besides regression test breakage that started with r117248.

You are right, the issue is in fact that the acid3 test does rely on visited link tracking.
It passes in the browser which tracks visited links, but the test misses the layoutTestController.keepWebHistory() call so it fails in DRT which properly disables visited links before each test, however the checked in failing platform independent result disguised this issue.
Before r117248 this was "fixed" on WK2 by the fact that visited link tracking was not disabled properly which gave a correct result with WTR, thus mac-wk2 needed its own result.
This test is skipped on Qt because of font metric issues which is really unfortunate, Qt needs a platform dependent result until the font issues are fixed.

I'll prepare a patch for the test and update the result tomorrow.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list