[Webkit-unassigned] [Bug 42679] WebKitTestRunner needs layoutTestController.setUserStyleSheetEnabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42679





--- Comment #12 from Dinu Jacob <dinu.jacob at Nokia.com>  2012-05-24 13:35:00 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > Thanks for the patch Dinu Jacob!
> > 
> > However setUserStyleSheetEnabled seems a good candidate to be added to window.internals.settings (WebCore/testing/InternalSettings) instead of LayoutTestController, because it just sets a property in the page's Settings.
> > 
> > That would avoid the creation of new private C API for the bundle, and possibly remove code from other ports. I did a similar patch for another setting in bug 42689. I am not a reviewer, but my suggestion is you go that route: add it to window.internals.settings.
> 
> Yes, it came to me as an after thought :( I will update the patch use Internals.

setUserStyleSheetEnabled is tied to setUserStyleSheetLocation. Currently Chromium retrieves the data from the css file and that is the string being set instead of the local file path in its dumpRenderTree implementation. Hence, can't use Internals Settings to replace the current implementation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.