[Webkit-unassigned] [Bug 85921] [chromium] Only increase size of Combo Box Options when displayed on touch screen

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85921


Rick Byers <rbyers at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rbyers at chromium.org




--- Comment #19 from Rick Byers <rbyers at chromium.org>  2012-05-24 10:52:05 PST ---
(In reply to comment #18)
> (From update of attachment 143602 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143602&action=review
> 
> > Source/WebCore/page/Settings.h:571
> > +        void setDeviceTouchScreen(bool enabled) { m_deviceTouchScreen = enabled; }
> > +        bool isDeviceTouchScreen() const { return m_deviceTouchScreen; }
> 
> Do you still need this to exist on WebCore::Settings?  If this only is ever set or queried on chromium's WebSettings, you can save the value in a bool on WebSettingsImpl and use that instead

I was about to start consuming this from WebCore to support the new pointer:coarse and hover:0 CSS media features: https://bugs.webkit.org/show_bug.cgi?id=87403.  Except I'm probably going to eventually want this to be tri-state: has touch screen, doesn't have touch screen, unknown (for ports that don't support it).  If this CL is good as is, I can convert it to tri-state as part of my bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.