[Webkit-unassigned] [Bug 87376] [Qt] NRWT and ORWT checks only for Skipped in platform/qt-5.0-wk1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87376


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143823|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #5 from Csaba Osztrogonac <ossy at webkit.org>  2012-05-24 07:31:04 PST ---
(From update of attachment 143823)
View in context: https://bugs.webkit.org/attachment.cgi?id=143823&action=review

Could you check if my suggestions are correct?

> Tools/Scripts/old-run-webkit-tests:2166
>          if ($platform eq "qt-5.0-wk2") {
>              push @platforms, $platform;
>          }
> +        elsif (getQtVersion() eq "5.0") {
> +            push @platforms, "qt-5.0-wk1"
> +        }

It isn't the best solution ... We don't want to use qt-5.0-wk1 Skipped list for Qt 4.8.

What do you think about this one?

if ($platform eq "qt-5.0-wk2" || getQtVersion() eq "5.0" && $useWebKitTestRunner) {
    push @platforms, "qt-5.0-wk2";
}
elsif ($platform eq "qt-5.0-wk1" || getQtVersion() eq "5.0" && !$useWebKitTestRunner) {
    push @platforms, "qt-5.0-wk1"
}

> Tools/Scripts/webkitpy/layout_tests/port/qt.py:118
>          if self.get_option('webkit_test_runner'):
>              search_paths.append(self._wk2_port_name())
> +        elif '5.0' in version:
> +            search_paths.append('qt-5.0-wk1')

It isn't so nice ...

What do you think about this one?

if '5.0' in version:
    if self.get_option('webkit_test_runner'):
        search_paths.append('qt-5.0-wk2')
    else:
        search_paths.append('qt-5.0-wk1')

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.