[Webkit-unassigned] [Bug 87337] [Blackberry] need call fullscreen APIs.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87337





--- Comment #5 from Chris.Guan <chris.guan at torchmobile.com.cn>  2012-05-24 07:17:56 PST ---
(In reply to comment #4)
> (From update of attachment 143732 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143732&action=review
> 
> Looks good, but could be improved more.
> 
> > Source/WebKit/blackberry/ChangeLog:9
> > +        chrom or it is not a video element. The webkitRequestFullScreen Javascript 
> 
> chrome
> 
> > Source/WebKit/blackberry/ChangeLog:11
> > +        to enter or exit full screen mode.
> 
> You probably want to reword the ChangeLog a bit:
> 
> Cover the case where no no fullscreen video widget has been made available by the Browser Chrome, or it is not a video element. In this case we call client's full screen APIs to enter or exit full screen mode.
> 
> > Source/WebKit/blackberry/Api/WebPageClient.h:239
> > +    virtual int fullscreenStart(const char* contextName = 0, Platform::Graphics::Window* = 0, unsigned x = 0, unsigned y = 0, unsigned width = 0, unsigned height = 0) = 0;
> 
> Do we care for the parameters at all if they are not handed over? Or is there some other place not in this patch that states these parameters?

Thanks, Rob. I should cancel r? earlier. see internal PR for more.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.