[Webkit-unassigned] [Bug 87337] [Blackberry] need call fullscreen APIs.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87337


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143732|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #2 from Antonio Gomes <tonikitoo at webkit.org>  2012-05-24 07:01:28 PST ---
(From update of attachment 143732)
View in context: https://bugs.webkit.org/attachment.cgi?id=143732&action=review

Some suggestions:

> Source/WebKit/blackberry/ChangeLog:9
> +        chrom or it is not a video element. The webkitRequestFullScreen Javascript 

chrom*

period should be a comma

> Source/WebKit/blackberry/Api/WebPageClient.h:239
> +    virtual int fullscreenStart(const char* contextName = 0, Platform::Graphics::Window* = 0, unsigned x = 0, unsigned y = 0, unsigned width = 0, unsigned height = 0) = 0;

is not it clear to add another method with parameters? adding 6 default values seems too much to me.

Then we can name one deprecatedFullScreenStart, and keep using the other.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.