[Webkit-unassigned] [Bug 87336] [WebSocket] WebSocket object should fire error event when WebSocket server can't be connected.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87336





--- Comment #5 from Yuta Kitamura <yutak at chromium.org>  2012-05-24 06:49:26 PST ---
(From update of attachment 143762)
View in context: https://bugs.webkit.org/attachment.cgi?id=143762&action=review

>>> Source/WebCore/ChangeLog:17
>>> +        simple event named error at the WebSocket object.
>> 
>> I'm not quite sure if these spec requirements have anything to do with the change itself. Could you add more explanations in your words?
> 
> If the WebSocket Server can't be connected and the underlying transport layer is unexpectedly lost,
> I think they should trigger the fail the WebSocket connection algorithm, fire the error event, not only send close event.
> In these scenarios, Firefox will fire error event at first, and then fire the close event.

Okay, so could you please put some sentences explaining the change to the ChangeLog? ChangeLog is the best place to put the rationale and brief overview of a patch. IMHO copy & pasting part of a specification in ChangeLog is not so friendly to readers.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.