[Webkit-unassigned] [Bug 84929] Add building gamepad module to CMake&GNUMake&QMake

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84929





--- Comment #8 from Zan Dobersek <zandobersek at gmail.com>  2012-05-23 23:18:59 PST ---
(From update of attachment 143725)
View in context: https://bugs.webkit.org/attachment.cgi?id=143725&action=review

Other than the following comments this looks OK for the GNUmakefiles.

> Source/WebCore/GNUmakefile.am:807
> +    $(WebCore)/Modules/gamepad \

A few more changes are required in GNUmakefile.am:
- '-I$(srcdir)/Source/WebCore/Modules/gamepad \' include path should be added to webcore_cppflags
- '$(shell ls $(srcdir)/Source/WebCore/Modules/gamepad/*.idl) \' file listing should be added to EXTRA_DIST

> Source/WebCore/GNUmakefile.list.am:1057
> +	Source/WebCore/Modules/gamepad/Gamepad.cpp \
> +	Source/WebCore/Modules/gamepad/Gamepad.h\
> +	Source/WebCore/Modules/gamepad/GamepadList.cpp \
> +	Source/WebCore/Modules/gamepad/GamepadList.h\
> +	Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp \
> +	Source/WebCore/Modules/gamepad/NavigatorGamepad.h

A few more changes are required in GNUmakefile.list.am:
- 'DerivedSources/WebCore/JSGamepad.(cpp|h)' and 'DerivedSources/WebCore/JSGamepadList.(cpp|h)' should be added to webcore_built_sources
- '$(WebCore)/Modules/gamepad/(Gamepad|GamepadList|NavigatorGamepad).idl' entries should be added to dom_binding_idls

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.