[Webkit-unassigned] [Bug 86719] Submit button doesn't submit the form if the form is wrapped by an anchor tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86719


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143687|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org>  2012-05-23 17:11:03 PST ---
(From update of attachment 143687)
View in context: https://bugs.webkit.org/attachment.cgi?id=143687&action=review

The code change looks good. We need more testing.

> LayoutTests/ChangeLog:9
> +        * fast/forms/form-in-anchor-controls-activation-expected.txt: Added.
> +        * fast/forms/form-in-anchor-controls-activation.html: Added.

Please add a test for non-form elements.

> LayoutTests/fast/forms/form-in-anchor-controls-activation.html:10
> +window.onload = function () {

Do we really need to wait until the load event fires? Can't we move this code to the script element below?

> LayoutTests/fast/forms/form-in-anchor-controls-activation.html:26
> +        /*
> +        (function (element) {
> +            element.addEventListener("click", function () {
> +                log("Activated " + element + " type=" + element.type);
> +            }, false);
> +        })(element);
> +        */

You should delete this code.

> LayoutTests/fast/forms/form-in-anchor-controls-activation.html:73
> +<script>
> +</script>

Why do we need this script element?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.